Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build on mac m1 #6560

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Dec 29, 2022

What problem does this PR solve?

Issue Number: close #6559

Problem Summary:

FAILED: dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsRegexp.cpp.o 
/Library/Developer/CommandLineTools/usr/bin/c++ -DBOOST_BIND_GLOBAL_PLACEHOLDERS -DBOOST_CONTEXT_EXPORT="" -DBOOST_CONTEXT_NO_LIB -DBOOST_CONTEXT_STATIC_LINK -DBOOST_FIBER_NO_LIB -DBOOST_FIBER_STATIC_LINK -DBOOST_NO_CXX98_FUNCTION_BASE -DBOOST_SYSTEM_NO_DEPRECATED -DCARES_STATICLIB -DFIU_ENABLE -DLZ4_DISABLE_DEPRECATE_WARNINGS=1 -DMULTIPLE_CONTEXT_GTEST -DPOCO_STATIC -DPOCO_UNBUNDLED_ZLIB -DTIFLASH_COMPILER_VPCLMULQDQ_SUPPORT=0 -DTIFLASH_ENABLE_ASIMD_SUPPORT=1 -DTIFLASH_SOURCE_PREFIX=\"/Users/qizhi/p/tiflash\" -I/Users/qizhi/p/tiflash/contrib/libdivide -I/Users/qizhi/p/tiflash/contrib/libmetrohash/src -I/Users/qizhi/p/tiflash/contrib/libfarmhash -I/Users/qizhi/p/tiflash/dbms/src -I/Users/qizhi/p/tiflash/contrib/tiflash-proxy/raftstore-proxy/ffi/src -I/Users/qizhi/p/tiflash/cmake-build-debug/dbms/src -I/Users/qizhi/p/tiflash/contrib/double-conversion -I/Users/qizhi/p/tiflash/contrib/boost -I/Users/qizhi/p/tiflash/contrib/xxHash -I/Users/qizhi/p/tiflash/contrib/libpcg-random/include -I/Users/qizhi/p/tiflash/contrib/libcityhash/include -I/Users/qizhi/p/tiflash/libs/libcommon/include -I/Users/qizhi/p/tiflash/cmake-build-debug/libs/libcommon/include -I/Users/qizhi/p/tiflash/libs/libpocoext/include -I/Users/qizhi/p/tiflash/contrib/poco/Data/include -I/Users/qizhi/p/tiflash/contrib/poco/Foundation/include -I/Users/qizhi/p/tiflash/contrib/zlib-ng -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/zlib-ng -I/Users/qizhi/p/tiflash/contrib/poco/Util/include -I/Users/qizhi/p/tiflash/contrib/poco/XML/include -I/Users/qizhi/p/tiflash/contrib/poco/JSON/include -I/Users/qizhi/p/tiflash/contrib/poco/Net/include -I/Users/qizhi/p/tiflash/contrib/cctz/include -I/Users/qizhi/p/tiflash/contrib/lz4/lib -I/Users/qizhi/p/tiflash/contrib/zstd/lib -I/Users/qizhi/p/tiflash/contrib/client-c/third_party/libfiu/libfiu -I/Users/qizhi/p/tiflash/contrib/prometheus-cpp/core/include -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/core/include -I/Users/qizhi/p/tiflash/contrib/prometheus-cpp/push/include -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/push/include -I/Users/qizhi/p/tiflash/contrib/prometheus-cpp/pull/include -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/pull/include -I/Users/qizhi/p/tiflash/contrib/cpptoml -I/Users/qizhi/p/tiflash/contrib/magic_enum/include -I/Users/qizhi/p/tiflash/contrib/poco/NetSSL_OpenSSL/include -I/Users/qizhi/p/tiflash/contrib/poco/Crypto/include -I/Users/qizhi/p/tiflash/contrib/xxHash/cmake_unofficial/.. -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/kvproto/cpp -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/kvproto/cpp/kvproto -I/Users/qizhi/p/tiflash/contrib/grpc/include -I/Users/qizhi/p/tiflash/contrib/abseil-cpp -I/Users/qizhi/p/tiflash/contrib/client-c/include -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/grpc/third_party/cares/cares -I/Users/qizhi/p/tiflash/contrib/grpc/third_party/cares/cares -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/tipb/cpp -I/Users/qizhi/p/tiflash/cmake-build-debug/dbms/src/Storages/DeltaMerge/File/dtpb -I/Users/qizhi/p/tiflash/contrib/libbtrie/include -I/Users/qizhi/p/tiflash/cmake-build-debug/contrib/libfarmhash -isystem /Users/qizhi/p/tiflash/contrib/fmtlib-cmake/../fmtlib/include -isystem /Users/qizhi/p/tiflash/libs/libsymbolization/include -isystem /Users/qizhi/p/tiflash/contrib/boringssl/include -isystem /Users/qizhi/p/tiflash/contrib/protobuf/src -isystem /Users/qizhi/p/tiflash/contrib/re2 -isystem /Users/qizhi/p/tiflash/cmake-build-debug/contrib/re2-cmake -pipe -march=armv8+crc+simd  -fno-omit-frame-pointer  -Wall -Wno-unused-command-line-argument  -Wnon-virtual-dtor  -Wextra -Werror -g -g3 -ggdb3 -O0 -fverbose-asm -fno-inline  -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk -fcolor-diagnostics -fPIC -DDUMMY_BACKTRACE -std=gnu++17 -MD -MT dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsRegexp.cpp.o -MF dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsRegexp.cpp.o.d -o dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsRegexp.cpp.o -c /Users/qizhi/p/tiflash/dbms/src/Functions/FunctionsRegexp.cpp
In file included from /Users/qizhi/p/tiflash/dbms/src/Functions/FunctionsRegexp.cpp:17:
In file included from /Users/qizhi/p/tiflash/dbms/src/Functions/FunctionsRegexp.h:35:
In file included from /Users/qizhi/p/tiflash/dbms/src/Functions/Regexps.h:16:
In file included from /Users/qizhi/p/tiflash/dbms/src/Common/OptimizedRegularExpression.h:145:
/Users/qizhi/p/tiflash/dbms/src/Common/OptimizedRegularExpression.inl.h:620:34: error: reinterpret_cast from 'long' to 'Int64' (aka 'long long') is not allowed
        auto skipped_byte_size = reinterpret_cast<Int64>(matched_str.data() - (subject + prior_offset));
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/qizhi/p/tiflash/dbms/src/Common/OptimizedRegularExpression.inl.h:683:16: note: in instantiation of member function 'OptimizedRegularExpressionImpl<false>::replaceAllImpl' requested here
        return replaceAllImpl(subject, subject_size, res_data, res_offset, repl, byte_pos);
               ^
/Users/qizhi/p/tiflash/dbms/src/Common/OptimizedRegularExpression.inl.h:739:5: note: in instantiation of member function 'OptimizedRegularExpressionImpl<false>::replaceImpl' requested here
    replaceImpl(subject, subject_size, res_data, res_offset, repl, byte_pos, occur);

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2022
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2022
@LittleFall
Copy link
Contributor Author

/run-all-tests

@xzhangxian1008
Copy link
Contributor

lgtm

@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 10e188f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2022
@LittleFall
Copy link
Contributor Author

/check-issue-triage-complete

@pingcap pingcap deleted a comment from ti-chi-bot Dec 29, 2022
@ti-chi-bot ti-chi-bot merged commit 4c8877e into pingcap:master Dec 29, 2022
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Jan 4, 2023
@LittleFall LittleFall deleted the chore/fix-build branch March 2, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fail in Mac
6 participants